Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[time_picker]start date display is not inclusive #16462

Closed
2 tasks
nguyenluongky opened this issue Aug 26, 2021 · 5 comments
Closed
2 tasks

[time_picker]start date display is not inclusive #16462

nguyenluongky opened this issue Aug 26, 2021 · 5 comments
Assignees
Labels
#bug Bug report explore:time Related to the time filters in Explore good first issue Good first issues for new contributors

Comments

@nguyenluongky
Copy link

nguyenluongky commented Aug 26, 2021

Currently, we use Native filter on Superset version 1.2, but looks like The actual time range does not show correctly with SIP-15 (in the SIP-15 the time range must is [inclusive, exclusive) ). So that mean the actual time range and the tool tip must show label as: from_date <= col < to_date.

Expected results

image

Actual results

image

Environment

(please complete the following information):

  • superset version: 1.2
  • python version: `3.7

Checklist

  • I have rated this issue on slack community and they advice me to create a ticket.
  • I tried with the config SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["inclusive", "inclusive"] but doesn't help.
@nguyenluongky nguyenluongky added the #bug Bug report label Aug 26, 2021
@junlincc junlincc changed the title The Actual time range not show correct with SIP-15 on Superset version 1.2 [time_picker]start date display is not inclusive Aug 26, 2021
@junlincc
Copy link
Member

thanks for reporting, if you click view query from dashboard with a time filter, you will notice the query is actually accurate even though the display is wrong. we will push a fix for the display soon.
Screen Shot 2021-08-26 at 10 53 54 AM
Screen Shot 2021-08-26 at 10 54 01 AM

@junlincc junlincc added good first issue Good first issues for new contributors explore:time Related to the time filters in Explore labels Aug 26, 2021
@junlincc junlincc self-assigned this Aug 26, 2021
@nguyenluongky
Copy link
Author

Thanks @junlincc ,
The query is correct, It is just a problem on UI only so it makes confuse for end-user then :).
And I also noted that this problem occurred because of Native filter doesn't submit the time_range_endpoints so by default it always use < operator to display. Correct me if I wrong.

@yongchand
Copy link
Contributor

Any updates for this issue? @junlincc

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@CodeingBoy
Copy link
Contributor

This bug was fixed in version 1.5.1 and should be marked as resolved.

@stale stale bot removed the inactive Inactive for >= 30 days label Jun 13, 2022
@rusackas rusackas closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report explore:time Related to the time filters in Explore good first issue Good first issues for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants