[dashboard][color theme] chart color are changed when refreshing dashboard

[jinghua-qa]

chart color are changed when refreshing dashboard

How to reproduce the bug

1. Go to dashboard with multiple charts
2. Applied color theme to dashboard, for example supers color
3. Refresh dashboard
4. Observe color of each chart
5. See error

Expected results

Refresh dashboard did not change color of chart

Actual results

Refresh dashboard did not change color of chart

Screenshots

color.change.when.refreshing.mov

Environment

(please complete the following information):

• browser type and version: Chrome
• superset version: master
• python version: python --version
• node.js version: node -v
• any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[junlincc]

@geido Let's create a new project in Projects, and manage color consistency ticket in one place https://github.com/apache/superset/projects/37

[amitmiran137]

confirming this issue as well in 1.3.1 version
we are working towards 1.3.2 with a few relevant fixes,
@junlincc @geido can this be prioritized ?
this is a critical bug for client-facing dashboards

[geido]

Hello @amitmiran137 I can move this to the top of my list. No problem

[amitmiran137]

@geido thanks friend ✌️

[D3nn3]

For us this happens again after migrating from 2.0.1 to 3.0.2. Can anyone else confirm?

[geido]

For us this happens again after migrating from 2.0.1 to 3.0.2. Can anyone else confirm?

Thanks for the heads up. We are investigating the issue. Please try to disable AVOID_COLORS_COLLISION and see if that fixes it

[D3nn3]

Thanks for the reply @geido . I did test it and it seemed to have helped int that regard but this introduced a new issue: two different labels in the same chart could have the same color (which imho is even worse).

Seems to me like one has to decide with v3 between one of the two:

• changing colors of labels when refreshing a dashboard page
• or the possibility of two labels in one chart having the same color

I don't know how others handle it currently on their production environment but for us this is fairly annoying and we couldn't find any solution to it. I'm surprised that only few other people are reporting this issue

[shubham19may]

Happening with us also. @geido in SS 3.0.x

[zakaryanla]

Actual for 3.0.3.
disable AVOID_COLORS_COLLISION helped

[progressive-scaler]

Actual for 3.1.0
I will test disabling AVOID_COLORS_COLLISION to see if its a valid workaround, or if the @D3nn3 collateral issue happens

Disabling AVOID_COLORS_COLLISION on the config file did not help :( so the problem still persists

[geido]

Thanks everyone for reporting these issues. Working on a longer term solution here #27439