Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset translation native filters bug #17779

Closed
3 tasks done
aeperalta opened this issue Dec 16, 2021 · 3 comments · Fixed by #26074
Closed
3 tasks done

Superset translation native filters bug #17779

aeperalta opened this issue Dec 16, 2021 · 3 comments · Fixed by #26074
Labels
#bug Bug report good first issue Good first issues for new contributors validation:validated A committer has validated / submitted the issue or it was reported by multiple users

Comments

@aeperalta
Copy link

How to reproduce the bug

  1. Active other language, for example, German in superset_config.py.
  2. Change the language of superset.
  3. Create a dashboard with some charts.
  4. Create a native filter of type 'Time grain' and other of type 'Time range'.
  5. Save the filter configuration.
  6. Click on time grain select. You will see the grains in english.
  7. The time range chip will be set to 'No filter', but if you click on it, you will see 'Kein Filter' (german) as selected in the Popup.

Expected results

The expected result of the Time grain select would be in german, and the chip in german too. I reviewed messages.po and messages.json and the translations are there. This happens in other languages that have the translations too.

Actual results

Time grain is in english, and the chip is in english too.

Screenshots

Granularity:
granularity

Time range chip:
Time range chip

Environment

  • browser type and version: Google Chrome Versión 96.0.4664.93
  • superset version: master head

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@aeperalta aeperalta added the #bug Bug report label Dec 16, 2021
@geido geido added the good first issue Good first issues for new contributors label Jan 25, 2022
@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas
Copy link
Member

@AndVK opened up a AWESOME PR that fixes this issue. I'll tag it so that it automatically closes this, if it gets a rebase and a couple of open questions answered.

@stale stale bot removed the inactive Inactive for >= 30 days label Jan 12, 2023
@rusackas rusackas added the validation:validated A committer has validated / submitted the issue or it was reported by multiple users label Jan 12, 2023
@hbruch
Copy link
Contributor

hbruch commented Mar 16, 2023

Most causes of the issues described here have been solved via #22150, which made many strings available for localization. In case they still not appear translated, the language specific .po file would need to be updated. See CONTRIBUTING for a how-to.

However, No filter for many charts still is not localized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report good first issue Good first issues for new contributors validation:validated A committer has validated / submitted the issue or it was reported by multiple users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants