Invalid assignment of ObjectType in saved_query list API

[akzarma]

There is wrong assignment of object_type here (it should be "query" instead of "saved_query")
Due to which, saved_query list API fails to load (when used databases except on sqlite - probably because sqlite does not strictly check enum type of object_type)

How to reproduce the bug

1. Setup backend database as postgres, Go to 'Saved Queries' page
2. You'll see an error popup right away and there are no saved queries shown.

Expected results

There should not be any error and saved queries should load fine

Actual results

• Shows error popup with sql error and there is no row of saved queries.

Screenshots

Environment

(please complete the following information):

browser type and version:
superset version: 2.1.0
python version: 3.9.14
node.js version: 16.17.1
any feature flags active: TAGGING_SYSTEM

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

[Antonio-RiveroMartnez]

I tried reproducing this issue locally with latest master version and I don't get the error message.

Screen.Recording.2023-04-06.at.10.37.05.mov

[akzarma]

@Antonio-RiveroMartnez what database is your local setup running on? it works fine for SQLite. I can repro it with postgres.

[Antonio-RiveroMartnez]

Yes, I am using Postgres and even my query is using it (You can verify in the video above for the selected Database). Are you using latest master or branch 2.1.0? If 2.1.0, could you try using latest master? Trying to see if it got already solved by some newer change after the 2.1.0 cut. Thanks @akzarma

[akzarma]

Yeah, my bad, I was some commits behind. it seems like it got resolved in the effect of #23526
However, The fix (#23611 ) I provided is still needed for the Tag feature to work on saved queries (which I think is half baked for saved queries)
My fix assigns the right object_type ("query") from the available types instead of "saved_query".

superset/superset/tags/models.py

Lines 66 to 74 in b820eb8

	class ObjectTypes(enum.Enum):
	"""Object types."""
	# pylint: disable=invalid-name
	query = 1
	chart = 2
	dashboard = 3
	dataset = 4

But yeah, this issue should be closed as the steps mentioned are not reproducing the bug.
Thanks @Antonio-RiveroMartnez

[Antonio-RiveroMartnez]

Awesome! Thanks to you @akzarma , I will close this now.