Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Search" box is last in search boxes for charts, datasets #25128

Closed
sfirke opened this issue Aug 30, 2023 · 0 comments · Fixed by #25129
Closed

"Search" box is last in search boxes for charts, datasets #25128

sfirke opened this issue Aug 30, 2023 · 0 comments · Fixed by #25129
Assignees
@sfirke

Comments

@sfirke
Copy link
Member

sfirke commented Aug 30, 2023

Should be first to match dashboards. "Search" was originally last for all three views, it was made first in this PR https://github.com/apache/superset/pull/19721/files but the corresponding change was not implemented for charts or datasets.

As of 2.1.0:

Correct:
image

Needs fixing to match:
image
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfirke sfirke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(frontend): make "Search" box the first filter for charts and datasets sfirke/superset
1 participant
@sfirke