Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs with the currency format control #25234

Closed
3 tasks done
michael-s-molina opened this issue Sep 8, 2023 · 5 comments
Closed
3 tasks done

Bugs with the currency format control #25234

michael-s-molina opened this issue Sep 8, 2023 · 5 comments
Assignees

Comments

@michael-s-molina
Copy link
Member

While testing the currency format control I found some bugs:

When you clear the currency format, the changes are not reflected in the viz.

Screen.Recording.2023-09-08.at.11.45.59.mov
Screen.Recording.2023-09-08.at.11.46.56.mov

These are just examples for Table and Pivot Table but we should check all supported charts for this problem. It seems the control is not handling the Select onClear event.

Currency format is not working for the Table chart when in Raw Records mode.

Screen.Recording.2023-09-08.at.11.50.09.mov

Environment

  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@michael-s-molina
Copy link
Member Author

@sadpandajoe @jinghua-qa

@michael-s-molina
Copy link
Member Author

TreeMap seems to be formatting the dimensions, which differs from the other chart types.

Screenshot 2023-09-08 at 13 14 42

For example, the PieChart preserves the Year format and only formats metrics.

Screenshot 2023-09-08 at 13 16 01

@michael-s-molina
Copy link
Member Author

@kgabryje I fixed the problem with clearing the Currency Format here.

@kgabryje
Copy link
Member

Fix for the treemap bug: #25249
Fix for raw table: #25248

@michael-s-molina
Copy link
Member Author

Closed by the referenced PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants