Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Permission to remove View Queries from Charts #31832

Closed
jamesjackson17 opened this issue Jan 14, 2025 · 1 comment
Closed

Add Permission to remove View Queries from Charts #31832

jamesjackson17 opened this issue Jan 14, 2025 · 1 comment
Labels
design:proposal Design proposals

Comments

@jamesjackson17
Copy link

jamesjackson17 commented Jan 14, 2025

Please make sure you are familiar with the SIP process documented
here. The SIP will be numbered by a committer upon acceptance.

Proposal for ...<title>

Motivation

We need to create a new permission that allows the removal of View Query from charts. As we do not wish this tho be visible to certain users.

Proposed Change

A new permission that allows the removal of View Query from charts.

New or Changed Public Interfaces

The addition of this permission will prevent users from being able to see the View Query on charts via the burger menu.
This is exclusively for charts as this functionality already exists for already created charts that appear on dashboards.

New dependencies

Permissions

Migration Plan and Compatibility

TBDs

Rejected Alternatives

TBD

@jamesjackson17 jamesjackson17 added the sip Superset Improvement Proposal label Jan 14, 2025
@dosubot dosubot bot added the design:proposal Design proposals label Jan 14, 2025
@rusackas
Copy link
Member

We discussed this, and feel that adding a permission does not require a SIP, as long as the relevant migrations are made. Also note that there's a forthcoming SIP to revamp the permissions model entirely, but that hasn't come to fruition yet.

I'd encourage you to open a PR if you need this feature, and include the use case for the new permission and why other permissions that exist today don't make sense.

I'll close this issue, but if you need further discussion, we can (re)open this as an "ideas" thread over on Discussions.

@rusackas rusackas removed the sip Superset Improvement Proposal label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:proposal Design proposals
Projects
None yet
Development

No branches or pull requests

2 participants