Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource selection for chart too limiting in 0.25 #4966

Closed
3 tasks done
kakoni opened this issue May 9, 2018 · 4 comments
Closed
3 tasks done

Datasource selection for chart too limiting in 0.25 #4966

kakoni opened this issue May 9, 2018 · 4 comments
Labels
inactive Inactive for >= 30 days

Comments

@kakoni
Copy link
Contributor

kakoni commented May 9, 2018

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.25.0

Issue

With #4746 User defined sql lab views don't anymore show up in the datasource select box. But atleast for our use case this is pretty limiting and perhaps it would make more sense to show all the datasources defined by current user in this select box?

@mistercrunch
Copy link
Member

How about an option to only show the user's own views on top of all tables?

@kakoni
Copy link
Contributor Author

kakoni commented May 18, 2018

@mistercrunch sorry, took some time to reply. So perhaps the easiest would be to add checkbox (not enabled by default) that says something like 'show all datasources' and then if you check it you get results as in 0.24 (some basically everything).

@villebro
Copy link
Member

villebro commented May 18, 2018

I agree with @kakoni. Also Renaming the SQL Lab View under table details to something more descriptive, like Exclude from datasources with description along the lines of "When checked, this table will not show up under Datasources unless 'show all datasources' checkbox is checked".

@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 10, 2019
@stale stale bot closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

3 participants