Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time filter from older versions break exploring slices from dashboard #5553

Closed
octaviancorlade opened this issue Aug 3, 2018 · 1 comment
Labels
inactive Inactive for >= 30 days

Comments

@octaviancorlade
Copy link
Contributor

Upgrading from 0.26.3 to the latest master branch, using a dashboard with "from" and "to" filters stored as dashboard metadata in the previous version, like

"default_filters": "{\"1234\": {\"__from\": \"15 days ago\", \"__to\": \"1 days ago\"}}"

Following #4981 these are not converted to the new __time_range filter and not being treated as date options in utils.merge_extra_filters they are used as filters instead:

"{"expressionType":"SIMPLE","subject":"__from","operator":"in","comparator":"15 days ago","clause":"WHERE","sqlExpression":null,"fromFormData":true,"filterOptionName":"63ad1398-eec0-449f-b0ae-7b8ab2c77b21"}"

Since the operator is "in" and the comparator is not an array, it also breaks when exploring any slice from that dashboard:

webpack:///./src/explore/AdhocFilter.js?:48 Uncaught TypeError: adhocMetric.comparator.join is not a function

@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 10, 2019
@stale stale bot closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant