From 27340cf19d37b9e26614932529b18e32f036f148 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 10 Nov 2020 15:56:51 -0800 Subject: [PATCH 1/6] adding bottom padding --- superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx b/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx index 28d3cb9c5390d..9dada34dda37d 100644 --- a/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx +++ b/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx @@ -68,8 +68,8 @@ const ActivityContainer = styled.div` } grid-gap: ${({ theme }) => theme.gridUnit * 8}px; justify-content: left; - padding: ${({ theme }) => theme.gridUnit * 2}px - ${({ theme }) => theme.gridUnit * 4}px; + padding: ${({ theme }) => theme.gridUnit * 6}px; + padding-top: ${({ theme }) => theme.gridUnit * 2}px; .ant-card-meta-avatar { margin-top: ${({ theme }) => theme.gridUnit * 3}px; margin-left: ${({ theme }) => theme.gridUnit * 2}px; From 38d9a1e98ad768973538c90ee00f47f346061906 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 10 Nov 2020 16:20:20 -0800 Subject: [PATCH 2/6] making light gray backgrounds match --- superset-frontend/stylesheets/less/variables.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/stylesheets/less/variables.less b/superset-frontend/stylesheets/less/variables.less index f47d0f9f1419f..67eb836e4de9b 100644 --- a/superset-frontend/stylesheets/less/variables.less +++ b/superset-frontend/stylesheets/less/variables.less @@ -49,7 +49,7 @@ @gray-dark: #484848; @gray-light: #cfd8dc; @gray: #879399; -@gray-bg: #f5f5f5; +@gray-bg: #F7F7F7; @gray-heading: #a3a3a3; @menu-hover: #f2f3f5; @lightest: #ffffff; From 4f4552b7e6d4487e2aa35399cbac1e6347d2da30 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 10 Nov 2020 16:26:05 -0800 Subject: [PATCH 3/6] vertical centering of empty state content. --- superset-frontend/src/views/CRUD/welcome/EmptyState.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/superset-frontend/src/views/CRUD/welcome/EmptyState.tsx b/superset-frontend/src/views/CRUD/welcome/EmptyState.tsx index 045ce7152b1b2..f6dea83cf0e8d 100644 --- a/superset-frontend/src/views/CRUD/welcome/EmptyState.tsx +++ b/superset-frontend/src/views/CRUD/welcome/EmptyState.tsx @@ -29,6 +29,9 @@ interface EmptyStateProps { } const EmptyContainer = styled.div` min-height: 200px; + display: flex; + flex-direction: column; + justify-content: space-around; `; const ButtonContainer = styled.div` Button { From f6af2e595636b7417d980132ca2bd496704d0755 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 10 Nov 2020 16:28:53 -0800 Subject: [PATCH 4/6] linting :sparkles: --- superset-frontend/stylesheets/less/variables.less | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/stylesheets/less/variables.less b/superset-frontend/stylesheets/less/variables.less index 67eb836e4de9b..52974c3e02e62 100644 --- a/superset-frontend/stylesheets/less/variables.less +++ b/superset-frontend/stylesheets/less/variables.less @@ -49,7 +49,7 @@ @gray-dark: #484848; @gray-light: #cfd8dc; @gray: #879399; -@gray-bg: #F7F7F7; +@gray-bg: #f7f7f7; @gray-heading: #a3a3a3; @menu-hover: #f2f3f5; @lightest: #ffffff; From d470ad136effea08eac238508beb8113e17a92ac Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 10 Nov 2020 16:34:33 -0800 Subject: [PATCH 5/6] fixing card radii --- superset-frontend/src/components/ListViewCard/index.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/superset-frontend/src/components/ListViewCard/index.tsx b/superset-frontend/src/components/ListViewCard/index.tsx index 5a159235e0f87..2505f33e169ee 100644 --- a/superset-frontend/src/components/ListViewCard/index.tsx +++ b/superset-frontend/src/components/ListViewCard/index.tsx @@ -37,6 +37,7 @@ const ActionsWrapper = styled.div` const StyledCard = styled(Card)` border: 1px solid #d9dbe4; + border-radius: ${({ theme }) => theme.gridUnit}px; .ant-card-body { padding: ${({ theme }) => theme.gridUnit * 4}px From 46d8d646a5bdf4d7ac8a2830a309b15d8fb292eb Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 10 Nov 2020 16:37:08 -0800 Subject: [PATCH 6/6] fixing corner radius... thumb was covering corner border. --- superset-frontend/src/components/ListViewCard/index.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/superset-frontend/src/components/ListViewCard/index.tsx b/superset-frontend/src/components/ListViewCard/index.tsx index 2505f33e169ee..5280c3d6d954c 100644 --- a/superset-frontend/src/components/ListViewCard/index.tsx +++ b/superset-frontend/src/components/ListViewCard/index.tsx @@ -38,6 +38,7 @@ const ActionsWrapper = styled.div` const StyledCard = styled(Card)` border: 1px solid #d9dbe4; border-radius: ${({ theme }) => theme.gridUnit}px; + overflow: hidden; .ant-card-body { padding: ${({ theme }) => theme.gridUnit * 4}px