Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove example token to avoid confusion #12967

Merged
merged 1 commit into from
Feb 5, 2021
Merged

chore: remove example token to avoid confusion #12967

merged 1 commit into from
Feb 5, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Feb 5, 2021

SUMMARY

Some may think the example GitHub token added in #12625 is real.

Let's just remove it to avoid future confusion.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Not needed

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

etr2460
etr2460 approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@ktmud ktmud merged commit 2456a2e into apache:master Feb 5, 2021
@ktmud ktmud deleted the github-token branch February 5, 2021 20:22
@junlincc
Copy link
Member

@ktmud sorry for the additional request. could you comment here what the risk(if there's any) is associate with this PR? 🙏

cc @guhan

@ktmud
Copy link
Member Author

ktmud commented Feb 10, 2021

@junlincc There is no risk. It's updating a code comment so people don't get unnecessarily alarmed on the risk of exposing an actual access token.

There is a thread in the committers channel in Slack on the day this PR was made.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ktmud @junlincc @etr2460 @mistercrunch