diff --git a/superset/viz.py b/superset/viz.py index b00a945ccc31a..456254bba3889 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -719,7 +719,7 @@ def query_obj(self) -> QueryObjectDict: sort_by = fd.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) d["orderby"] = [(sort_by, not fd.get("order_desc", True))] elif d["metrics"]: @@ -847,7 +847,7 @@ def query_obj(self) -> QueryObjectDict: sort_by = self.form_data.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) if self.form_data.get("order_desc"): d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))] @@ -951,11 +951,10 @@ class TreemapViz(BaseViz): def query_obj(self) -> QueryObjectDict: d = super().query_obj() - metrics = self.form_data.get("metrics") sort_by = self.form_data.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) if self.form_data.get("order_desc"): d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))] @@ -1637,11 +1636,10 @@ class NVD3TimeSeriesStackedViz(NVD3TimeSeriesViz): def query_obj(self) -> QueryObjectDict: d = super().query_obj() - metrics = self.form_data.get("metrics") sort_by = self.form_data.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) if self.form_data.get("order_desc"): d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))] @@ -1729,7 +1727,7 @@ def query_obj(self) -> QueryObjectDict: sort_by = fd.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) d["orderby"] = [(sort_by, not fd.get("order_desc", True))] elif d["metrics"]: @@ -2103,7 +2101,7 @@ def query_obj(self) -> QueryObjectDict: sort_by = self.form_data.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) if self.form_data.get("order_desc"): d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))] @@ -2190,7 +2188,7 @@ def query_obj(self) -> QueryObjectDict: sort_by = self.form_data.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) if self.form_data.get("order_desc"): d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))] @@ -2818,7 +2816,7 @@ def query_obj(self) -> QueryObjectDict: sort_by = self.form_data.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) if self.form_data.get("order_desc"): d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))] @@ -2881,11 +2879,10 @@ class RoseViz(NVD3TimeSeriesViz): def query_obj(self) -> QueryObjectDict: d = super().query_obj() - metrics = self.form_data.get("metrics") sort_by = self.form_data.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in d["metrics"]: + if sort_by_label not in utils.get_metric_names(d["metrics"]): d["metrics"].append(sort_by) if self.form_data.get("order_desc"): d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))] @@ -2932,7 +2929,7 @@ def query_obj(self) -> QueryObjectDict: sort_by = self.form_data.get("timeseries_limit_metric") if sort_by: sort_by_label = utils.get_metric_name(sort_by) - if sort_by_label not in query_obj["metrics"]: + if sort_by_label not in utils.get_metric_names(query_obj["metrics"]): query_obj["metrics"].append(sort_by) query_obj["orderby"] = [ (sort_by, not self.form_data.get("order_desc", True))