From 9ce7609be62b7a400571eef386be16b322322aed Mon Sep 17 00:00:00 2001
From: Bruno Motta <wadge.motta@gmail.com>
Date: Wed, 10 Mar 2021 15:24:08 -0300
Subject: [PATCH] Tests for useChangeEffect

---
 .../src/common/hooks/useChangeEffect/index.ts | 20 +++++++
 .../useChangeEffect/useChangeEffect.test.ts   | 54 +++++++++++++++++++
 .../{ => useChangeEffect}/useChangeEffect.ts  |  2 +-
 3 files changed, 75 insertions(+), 1 deletion(-)
 create mode 100644 superset-frontend/src/common/hooks/useChangeEffect/index.ts
 create mode 100644 superset-frontend/src/common/hooks/useChangeEffect/useChangeEffect.test.ts
 rename superset-frontend/src/common/hooks/{ => useChangeEffect}/useChangeEffect.ts (96%)

diff --git a/superset-frontend/src/common/hooks/useChangeEffect/index.ts b/superset-frontend/src/common/hooks/useChangeEffect/index.ts
new file mode 100644
index 0000000000000..15ccea1b8c1e6
--- /dev/null
+++ b/superset-frontend/src/common/hooks/useChangeEffect/index.ts
@@ -0,0 +1,20 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+export * from './useChangeEffect';
diff --git a/superset-frontend/src/common/hooks/useChangeEffect/useChangeEffect.test.ts b/superset-frontend/src/common/hooks/useChangeEffect/useChangeEffect.test.ts
new file mode 100644
index 0000000000000..32c984e48769b
--- /dev/null
+++ b/superset-frontend/src/common/hooks/useChangeEffect/useChangeEffect.test.ts
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { renderHook } from '@testing-library/react-hooks';
+import { useChangeEffect } from './useChangeEffect';
+
+test('call callback the first time with undefined and value', () => {
+  const callback = jest.fn();
+  renderHook(props => useChangeEffect(props.value, props.callback), {
+    initialProps: { value: 'value', callback },
+  });
+  expect(callback).toBeCalledTimes(1);
+  expect(callback).nthCalledWith(1, undefined, 'value');
+});
+
+test('do not call callback 2 times if the value do not change', () => {
+  const callback = jest.fn();
+  const hook = renderHook(
+    props => useChangeEffect(props.value, props.callback),
+    {
+      initialProps: { value: 'value', callback },
+    },
+  );
+  hook.rerender({ value: 'value', callback });
+  expect(callback).toBeCalledTimes(1);
+});
+
+test('call callback whenever the value changes', () => {
+  const callback = jest.fn();
+  const hook = renderHook(
+    props => useChangeEffect(props.value, props.callback),
+    {
+      initialProps: { value: 'value', callback },
+    },
+  );
+  hook.rerender({ value: 'value-2', callback });
+  expect(callback).toBeCalledTimes(2);
+  expect(callback).nthCalledWith(2, 'value', 'value-2');
+});
diff --git a/superset-frontend/src/common/hooks/useChangeEffect.ts b/superset-frontend/src/common/hooks/useChangeEffect/useChangeEffect.ts
similarity index 96%
rename from superset-frontend/src/common/hooks/useChangeEffect.ts
rename to superset-frontend/src/common/hooks/useChangeEffect/useChangeEffect.ts
index c16be99d265d2..ecda859debe1c 100644
--- a/superset-frontend/src/common/hooks/useChangeEffect.ts
+++ b/superset-frontend/src/common/hooks/useChangeEffect/useChangeEffect.ts
@@ -18,7 +18,7 @@
  */
 
 import { useEffect } from 'react';
-import { usePrevious } from './usePrevious';
+import { usePrevious } from '../usePrevious';
 
 /**
  * Calls the callback when the value changes.