From 5528a6896004a51b0ea476a76f329a5f9c397e7f Mon Sep 17 00:00:00 2001 From: Sam Firke Date: Wed, 30 Aug 2023 16:06:30 +0000 Subject: [PATCH 1/2] move search box first for chart list --- superset-frontend/src/pages/ChartList/index.tsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/superset-frontend/src/pages/ChartList/index.tsx b/superset-frontend/src/pages/ChartList/index.tsx index e94dc426b1b92..e47f479811fab 100644 --- a/superset-frontend/src/pages/ChartList/index.tsx +++ b/superset-frontend/src/pages/ChartList/index.tsx @@ -589,6 +589,13 @@ function ChartList(props: ChartListProps) { const filters: Filters = useMemo(() => { const filters_list = [ + { + Header: t('Search'), + key: 'search', + id: 'slice_name', + input: 'search', + operator: FilterOperator.chartAllText, + }, { Header: t('Owner'), key: 'owner', @@ -705,13 +712,6 @@ function ChartList(props: ChartListProps) { fetchSelects: loadTags, }); } - filters_list.push({ - Header: t('Search'), - key: 'search', - id: 'slice_name', - input: 'search', - operator: FilterOperator.chartAllText, - }); return filters_list; }, [addDangerToast, favoritesFilter, props.user]); From edb9a194491f75de1058dc3e28408bfad25411bd Mon Sep 17 00:00:00 2001 From: Sam Firke Date: Wed, 30 Aug 2023 16:44:54 +0000 Subject: [PATCH 2/2] move search box to left for datasets --- superset-frontend/src/pages/DatasetList/index.tsx | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/superset-frontend/src/pages/DatasetList/index.tsx b/superset-frontend/src/pages/DatasetList/index.tsx index 0f3fb84ab181e..76d96757c08ed 100644 --- a/superset-frontend/src/pages/DatasetList/index.tsx +++ b/superset-frontend/src/pages/DatasetList/index.tsx @@ -521,6 +521,13 @@ const DatasetList: FunctionComponent = ({ const filterTypes: Filters = useMemo( () => [ + { + Header: t('Search'), + key: 'search', + id: 'table_name', + input: 'search', + operator: FilterOperator.contains, + }, { Header: t('Owner'), key: 'owner', @@ -598,13 +605,6 @@ const DatasetList: FunctionComponent = ({ { label: t('No'), value: false }, ], }, - { - Header: t('Search'), - key: 'search', - id: 'table_name', - input: 'search', - operator: FilterOperator.contains, - }, ], [user], );