-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add latest docker tag #25322
chore: add latest docker tag #25322
Conversation
Nice @eschutho !! ❤️ Lots of nice changes here, I need to be properly awake before reviewing this one 🙂 |
I’ve got a few test errors to take care of, by the looks of it. Kudos to @sfirke for heading up this initiative. |
Thank you for making this happen! It will be such a nice improvement for the new user experience. |
5f4c9af
to
53da09c
Compare
/testenv up |
@eschutho Ephemeral environment spinning up at http://34.217.102.204:8080. Credentials are |
Hi, I'm just curious. Why is a new tag introduced, which could possibly cause more confusion between Current:
This PR:
Why not point latest to the actual latest release:
|
scripts/docker_build_push.sh
Outdated
|
||
# | ||
# Build the "lean39" image | ||
# | ||
DOCKER_BUILDKIT=1 docker build --target lean \ | ||
-t "${REPO_NAME}:${SHA}-py39" \ | ||
-t "${REPO_NAME}:${REFSPEC}-py39" \ | ||
-t "${REPO_NAME}:${LATEST_TAG}-py39" \ | ||
--build-arg PY_VER="3.9-slim-bullseye"\ | ||
--label "sha=${SHA}" \ | ||
--label "built_at=$(date)" \ | ||
--label "target=lean39" \ | ||
--label "build_actor=${GITHUB_ACTOR}" \ | ||
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a new image based on a different base image (bookworm
vs bullseye
)? I think instead of creating a new lean39
image based on bullseye
, you could just add the -py39
tag to the already existing lean
image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also received feedback from the community that they would like to see an image based on bullseye, so we're considering supporting a few versions of Ubuntu instead of just one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
understood, thanks!
Hi @sebastianliebscher. I agree that |
53da09c
to
2ec02b5
Compare
2ec02b5
to
c4ec9c1
Compare
85db6ac
to
d98ea78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I agree with @eschutho that moving latest from what it currently is to 3.0 release will end up breaking lots of deployments out there, it'll be a difficult change and will results in lots of issues on github and slack since migrations will be broken. I think we should eventually strive to get there, the way to do that would probably be to stop publishing |
@eschutho, understood - thank you for clarifying this. My thought was: Why introducing an uncommon tag as a "workaround" and not fix the latest tag instead. If you currently use the I now know the background and don't want to get in anyone's way here. Thank you both for your answers 👍 |
I love this idea from @nytai as a way to get there while avoiding the breaking described by @eschutho. Should we stop publishing |
Thanks everyone for this feedback. It sounds like we have a path forward. I'll follow up with a PR to stop tagging |
Ephemeral environment shutdown and build artifacts deleted. |
# for the dev image, it's ok to tag master as latest-dev | ||
# for production, we only want to tag the latest release as latest | ||
if [ "${LATEST_TAG}" = "master" ]; then | ||
DEV_TAG="${REPO_NAME}:latest-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that for dev, people want to continue to use master.
2c5f324
to
c54274c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
SUMMARY
This adds a new tag for docker with "latest" for all releases where the release tag is the most recent.
The next step would be to update docs and docker-compose files for new installs to point to the latest official release instead of master.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION