-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sqllab): Add keyboard shortcut helper #25542
feat(sqllab): Add keyboard shortcut helper #25542
Conversation
@kasiazjc could you help the design review? |
@justinpark This is really cool! |
/testenv up |
@eschutho Ephemeral environment spinning up at http://34.216.203.161:8080. Credentials are |
@justinpark thank you for working on this, definitely a needed feature! I have a few suggestions:
![]()
What do you think? |
39e202f
to
29c4bea
Compare
@kasiazjc Thanks for the suggestion! I made the layout change and menu location as you suggested. ![]() |
I don't find the issue. |
Thank you for the quick changes, this looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
design LGTM
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This commit adds keyboard shortcut helper button to display keyboard shortcut list.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after--keyboard-shortcut.mov
TESTING INSTRUCTIONS
Go to SQL Lab and click shortcut button
ADDITIONAL INFORMATION