From 56f0971eff4a818ee9c35fe3636d09a3407d2730 Mon Sep 17 00:00:00 2001
From: Denny Biasiolli <denny.biasiolli@gmail.com>
Date: Sat, 29 Apr 2017 19:19:22 +0200
Subject: [PATCH 1/5] tests: adding required props to FilterableTable
 mockedProps

---
 .../components/FilterableTable/FilterableTable_spec.jsx    | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx b/superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx
index f0de6f7ce2f29..240a8e499a10c 100644
--- a/superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx
+++ b/superset/assets/spec/javascripts/components/FilterableTable/FilterableTable_spec.jsx
@@ -4,7 +4,12 @@ import { expect } from 'chai';
 import FilterableTable from '../../../../javascripts/components/FilterableTable/FilterableTable';
 
 describe('FilterableTable', () => {
+  const mockedProps = {
+    orderedColumnKeys: [],
+    data: [],
+    height: 0,
+  };
   it('is valid element', () => {
-    expect(React.isValidElement(<FilterableTable />)).to.equal(true);
+    expect(React.isValidElement(<FilterableTable {...mockedProps} />)).to.equal(true);
   });
 });

From 1e878403362a4b3523781bc1f3113f9f4914a667 Mon Sep 17 00:00:00 2001
From: Denny Biasiolli <denny.biasiolli@gmail.com>
Date: Sat, 29 Apr 2017 19:20:17 +0200
Subject: [PATCH 2/5] tests: adding required prop `height` to QuerySearch
 mockedProps

---
 superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx | 1 +
 1 file changed, 1 insertion(+)

diff --git a/superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx b/superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx
index be0bbebb8dd49..e68ebd062226d 100644
--- a/superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/QuerySearch_spec.jsx
@@ -11,6 +11,7 @@ import QuerySearch from '../../../javascripts/SqlLab/components/QuerySearch';
 describe('QuerySearch', () => {
   const mockedProps = {
     actions: {},
+    height: 0,
   };
   it('is valid', () => {
     expect(

From 19afca0c698f07e193050ad86bb5a8458a2fce4d Mon Sep 17 00:00:00 2001
From: Denny Biasiolli <denny.biasiolli@gmail.com>
Date: Sat, 29 Apr 2017 19:21:55 +0200
Subject: [PATCH 3/5] tests: adding required prop `height` to ResultSet
 mockedProps

---
 .../assets/spec/javascripts/sqllab/ResultSet_spec.jsx  | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/superset/assets/spec/javascripts/sqllab/ResultSet_spec.jsx b/superset/assets/spec/javascripts/sqllab/ResultSet_spec.jsx
index 3c46aa2f9ecb2..7e5cd15c7722c 100644
--- a/superset/assets/spec/javascripts/sqllab/ResultSet_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/ResultSet_spec.jsx
@@ -9,14 +9,10 @@ import { queries } from './fixtures';
 describe('ResultSet', () => {
   const mockedProps = {
     query: queries[0],
+    height: 0,
   };
-  it('renders', () => {
-    expect(React.isValidElement(<ResultSet />)).to.equal(true);
-  });
-  it('renders with props', () => {
-    expect(
-      React.isValidElement(<ResultSet />),
-    ).to.equal(true);
+  it('is valid', () => {
+    expect(React.isValidElement(<ResultSet {...mockedProps} />)).to.equal(true);
   });
   it('renders a Table', () => {
     const wrapper = shallow(<ResultSet {...mockedProps} />);

From 55f854c7732d0702eefa5c8f66cbfa432189b1df Mon Sep 17 00:00:00 2001
From: Denny Biasiolli <denny.biasiolli@gmail.com>
Date: Sat, 29 Apr 2017 19:22:47 +0200
Subject: [PATCH 4/5] tests: adding required prop `height` to SqlEditorLeftBar
 mockedProps

---
 .../assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx     | 1 +
 1 file changed, 1 insertion(+)

diff --git a/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx b/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
index 42fcd14c6b321..c20c1a6cb9aa0 100644
--- a/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/SqlEditorLeftBar_spec.jsx
@@ -12,6 +12,7 @@ describe('SqlEditorLeftBar', () => {
   const mockedProps = {
     tables: [table],
     queryEditor: defaultQueryEditor,
+    height: 0,
   };
   it('is valid', () => {
     expect(

From 3f8b3b4bb278ff31f2da00139c2f7b827138f286 Mon Sep 17 00:00:00 2001
From: Denny Biasiolli <denny.biasiolli@gmail.com>
Date: Sat, 29 Apr 2017 19:24:03 +0200
Subject: [PATCH 5/5] tests: fix warning in Timer component

---
 superset/assets/spec/javascripts/sqllab/Timer_spec.jsx | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/superset/assets/spec/javascripts/sqllab/Timer_spec.jsx b/superset/assets/spec/javascripts/sqllab/Timer_spec.jsx
index 4d62a7ae11ccb..9bad34c32ee7b 100644
--- a/superset/assets/spec/javascripts/sqllab/Timer_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/Timer_spec.jsx
@@ -14,10 +14,7 @@ describe('Timer', () => {
     isRunning: true,
     state: 'warning',
   };
-  it('renders', () => {
-    expect(React.isValidElement(<Timer />)).to.equal(true);
-  });
-  it('renders with props', () => {
+  it('is valid', () => {
     expect(React.isValidElement(<Timer {...mockedProps} />))
     .to.equal(true);
   });