Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add lint check for newlines #11609

Closed
driazati opened this issue Jun 7, 2022 · 2 comments
Closed

[ci] Add lint check for newlines #11609

driazati opened this issue Jun 7, 2022 · 2 comments
Labels
dev:ci

Comments

@driazati
Copy link
Member

driazati commented Jun 7, 2022 •
edited by github-actions bot
Loading

See #11560, CI should enforce that every file uses LF and has a trailing newline aside from exceptional cases

cc @Mousius @areusch @gigiblender
@driazati driazati mentioned this issue Jun 7, 2022
Merged
@areusch
Copy link
Contributor

areusch commented Jun 10, 2022

cc @hpanda-naut can you triage?

@areusch areusch added the needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it label Oct 19, 2022
@hpanda-naut hpanda-naut added dev:ci and removed needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it labels Nov 15, 2022
@driazati
Copy link
Member Author

driazati commented Dec 6, 2022

this is done now in tests/lint/whitespace.sh

@driazati driazati closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:ci
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@areusch @driazati @hpanda-naut