Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] v0.14.0 release schedule #15812

Closed
18 tasks done
ysh329 opened this issue Sep 24, 2023 · 15 comments
Closed
18 tasks done

[Release] v0.14.0 release schedule #15812

ysh329 opened this issue Sep 24, 2023 · 15 comments
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug

Comments

@ysh329
Copy link
Contributor

ysh329 commented Sep 24, 2023 •
edited
Loading

Last release v0.13.0 is on 14 July and the branch cut day is 1 July v0.13.0 release schedule. It has been almost three months since 1 July. According to our RFC-0067 about quarter-based releases, I hope to release v0.14.0 version in mid Oct. It's meaningful especially for AI infra companies which needs regularly merge with release version.
In order to continue with our agreed release cycle as per discussion in RFC#67 , I'd like to propose a schedule for our next TVM release: v0.14.0.

This schedule is tentative and may change as we progress through the process. In case dates change, this thread will be kept updated.

The proposed schedule is:

Call for release managers: In case you want to be involved in upcoming releases, please manifest your interest in this thread and we'll try to organise. 😆

See also:

cc @apache/tvm-committers @Hzfengsy @vinx13 @areusch @Mousius @tqchen @AndrewZhaoLuo
@ysh329 ysh329 added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug labels Sep 24, 2023
@ysh329
Copy link
Contributor Author

ysh329 commented Sep 24, 2023 •
edited
Loading

Here, let me explan why do first version modification to v0.14.0 on main branch.

Considering downstream companies need regularly do code merge with release code, each time version modification is after cut branch. In other words, each version modification commit is not on git main tree (and after branch cut we do version modification on main, two branch divergence), which results in code conflict such as version number between codebase of downstream companies and latest upstream release.

@ysh329
Copy link
Contributor Author

ysh329 commented Oct 15, 2023

Hi all, due to a new idea about release flow before and after cut branch, this release may delay. More informations can refer below PRs:

@ysh329
Copy link
Contributor Author

ysh329 commented Oct 16, 2023 •
edited
Loading

Hi all, with help of @Hzfengsy, branch v0.14.0 was created. However, because PR about version modification merged without sqaush, related commit is unverified, more concretely referring Rebased commits by the web interface aren't signed.

Thus, this unverfied commit about version modification whether exists potential risks on v0.14.0 sush as chain reaction, especially when cherry-pick is required. It may be necessary to do some experiments such as Cherry Pick, but there are currently no new commit merged on main.

@ysh329
Copy link
Contributor Author

ysh329 commented Oct 18, 2023 •
edited
Loading

Hi all, with help of @Hzfengsy, branch v0.14.0 was created. However, because PR about version modification merged without sqaush, related commit is unverified, more concretely referring Rebased commits by the web interface aren't signed.

Thus, this unverfied commit about version modification whether exists potential risks on v0.14.0 sush as chain reaction, especially when cherry-pick is required. It may be necessary to do some experiments such as Cherry Pick, but there are currently no new commit merged on main.

I made a bugfix cherry-pick PR to branch v0.14.0: #15946, to check this new flow whether any problem exists.

@ysh329
Copy link
Contributor Author

ysh329 commented Oct 24, 2023 •
edited
Loading

Hi all, with help of @Hzfengsy , candidate package uploaded.

Check sha512

@ysh329 ➜ /workspaces/tmp $ shasum -a 512 ./apache-tvm-src-v0.14.0.rc0.tar.gz
223335470a249f3bd357ac385f6b7820dc6b400e572e71f8180107e7d8c2960a3e1dd6ee89327f65072d643c324c09b91b16586ecdf7bfc8eb4d7a0a17de0b27  ./apache-tvm-src-v0.14.0.rc0.tar.gz
@ysh329 ➜ /workspaces/tmp $ cat ./apache-tvm-src-v0.14.0.rc0.tar.gz.sha512 
223335470a249f3bd357ac385f6b7820dc6b400e572e71f8180107e7d8c2960a3e1dd6ee89327f65072d643c324c09b91b16586ecdf7bfc8eb4d7a0a17de0b27  apache-tvm-src-v0.14.0.rc0.tar.gz

Check asc

@ysh329 ➜ /workspaces/tmp/apache-tvm-src-v0.14.0 $ gpg --import ./KEYS
gpg: key 6754EA97C55E3DEB: public key "Tianqi Chen (CODE SIGNING KEY) <[email protected]>" imported
gpg: key 8955D84E20C9AB0C: public key "Yizhi Liu <[email protected]>" imported
gpg: key 3A709F6F2B86E9D6: public key "Yizhi Liu (Yizhi Liu at Apache) <[email protected]>" imported
gpg: key CA751254E97B9FE4: public key "Yizhi Liu <[email protected]>" imported
gpg: key ED03B26E4FC3509F: public key "Ziheng Jiang <[email protected]>" imported
gpg: key 9FBECBD3D75EFD4B: public key "Zhi Chen <[email protected]>" imported
gpg: key 35ABC9676004ADAE: public key "Junru Shao <[email protected]>" imported
gpg: key 2C75E5A496C80880: public key "Wuwei Lin <[email protected]>" imported
gpg: key 07FA463F1C926F48: public key "David Riazati <[email protected]>" imported
gpg: key C9A56ABD5CCA3EB8: public key "Andrew Zhao Luo <[email protected]>" imported
gpg: key 28D4862222B8EC31: public key "Leandro Nunes <[email protected]>" imported
gpg: key 06D051CA84EF3749: public key "Siyuan Feng (CODE SIGNING KEY) <[email protected]>" imported
gpg: Total number processed: 12
gpg:               imported: 12
@ysh329 ➜ /workspaces/tmp/apache-tvm-src-v0.14.0 $ gpg --edit-key 664EF29634C05669C3DCF83106D051CA84EF3749
gpg (GnuPG) 2.2.19; Copyright (C) 2019 Free Software Foundation, Inc.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.


pub  rsa4096/06D051CA84EF3749
     created: 2023-05-05  expires: never       usage: SC  
     trust: unknown       validity: unknown
sub  rsa4096/D0064A60FA06DD20
     created: 2023-05-05  expires: never       usage: E   
[ unknown] (1). Siyuan Feng (CODE SIGNING KEY) <[email protected]>

gpg> trust
pub  rsa4096/06D051CA84EF3749
     created: 2023-05-05  expires: never       usage: SC  
     trust: unknown       validity: unknown
sub  rsa4096/D0064A60FA06DD20
     created: 2023-05-05  expires: never       usage: E   
[ unknown] (1). Siyuan Feng (CODE SIGNING KEY) <[email protected]>

Please decide how far you trust this user to correctly verify other users' keys
(by looking at passports, checking fingerprints from different sources, etc.)

  1 = I don't know or won't say
  2 = I do NOT trust
  3 = I trust marginally
  4 = I trust fully
  5 = I trust ultimately
  m = back to the main menu

Your decision? 5
Do you really want to set this key to ultimate trust? (y/N) y

pub  rsa4096/06D051CA84EF3749
     created: 2023-05-05  expires: never       usage: SC  
     trust: ultimate      validity: unknown
sub  rsa4096/D0064A60FA06DD20
     created: 2023-05-05  expires: never       usage: E   
[ unknown] (1). Siyuan Feng (CODE SIGNING KEY) <[email protected]>
Please note that the shown key validity is not necessarily correct
unless you restart the program.

gpg> quit
@ysh329 ➜ /workspaces/tmp/apache-tvm-src-v0.14.0 $ gpg --verify ../apache-tvm-src-v0.14.0.rc0.tar.gz.asc ../apache-tvm-src-v0.14.0.rc0.tar.gz
gpg: Signature made Mon Oct 23 07:30:46 2023 UTC
gpg:                using RSA key 664EF29634C05669C3DCF83106D051CA84EF3749
gpg: checking the trustdb
gpg: marginals needed: 3  completes needed: 1  trust model: pgp
gpg: depth: 0  valid:   2  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 2u
gpg: next trustdb check due at 2025-10-14
gpg: Good signature from "Siyuan Feng (CODE SIGNING KEY) <[email protected]>" [ultimate]

Check binary in source code

# check binary
$ find ./apache-tvm-src-v0.14.0 -type f -exec file {} + | grep -w "ELF\|shared object"
# find nothing

Compile and Python Import on Linux

Passed with default config.

@ysh329
Copy link
Contributor Author

ysh329 commented Oct 24, 2023 •
edited
Loading

Hi all, vote starts (#15974). Everyone is welcomed to vote. Please vote by replying to this thread (#15974) explicitly. Vote will close Oct. 30th at 23:59M GMT.

@ysh329 ysh329 mentioned this issue Oct 31, 2023
Closed
@ysh329
Copy link
Contributor Author

ysh329 commented Oct 31, 2023

Hi all, vote passes, next we'll upload the binaries to Apache mirrors and create a new release TAG named v0.14.0 meanwhile remove the pre-release candidate TAG v0.14.0.rc0. This program needs help please.

Besides, we need update doc website too. According to last release talk as below, this step would need ASF perm.

cc @Hzfengsy @vinx13 @tqchen

@ysh329
Copy link
Contributor Author

ysh329 commented Nov 1, 2023

Due to this release with new release flow about version number modification, I made a PR for release docs: #16024.

@ysh329
Copy link
Contributor Author

ysh329 commented Nov 17, 2023

Hi @vinx13 , can you help update docs to website?

@ysh329 ysh329 mentioned this issue Dec 26, 2023
Open
17 tasks
@ysh329
Copy link
Contributor Author

ysh329 commented Dec 26, 2023

Hi all, do we have an example of how to generate website documents?
Based on our previous release experience, currently the method of generating website documents in TVM documents is not working.

@vinx13
Copy link
Member

vinx13 commented Jan 2, 2024

the documents can be built via docker or downloaded from the built artifacts generated by CI (there's a link in the ci output). we should update the website with this process

@ysh329
Copy link
Contributor Author

ysh329 commented Jan 2, 2024 •
edited
Loading

the documents can be built via docker or downloaded from the built artifacts generated by CI (there's a link in the ci output). we should update the website with this process

Let me have a try. It sounds trouble via docker. I didn't find link in cherry-pick PR CI output: https://github.com/apache/tvm/actions/runs/6559196548/job/17814307171, from this PR (#15946)

@vinx13
Copy link
Member

vinx13 commented Jan 2, 2024 •
edited
Loading

the link is in Jenkins ci step that uploads the artifact, it looks like I already pushed the doc a few months ago https://github.com/apache/tvm-site/tree/asf-site/docs/v0.14.0

@vinx13
Copy link
Member

vinx13 commented Jan 2, 2024

it's possible that we modify jenkinsfile to enable automatic deployment of docs for release branch https://github.com/apache/tvm/blob/main/ci/jenkins/templates/gpu_jenkinsfile.groovy.j2#L157-L215

@ysh329
Copy link
Contributor Author

ysh329 commented Jan 2, 2024

it's possible that we modify jenkinsfile to enable automatic deployment of docs for release branch https://github.com/apache/tvm/blob/main/ci/jenkins/templates/gpu_jenkinsfile.groovy.j2#L157-L215

Great! Let me familiarize myself with this Jenkins.

@ysh329 ysh329 closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vinx13 @ysh329