Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay]Disable InferType if it was done and no changes after previous pass #17585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elvin-n
Copy link
Contributor

@elvin-n elvin-n commented Jan 8, 2025

This optimization allows to speedup PatternRewriter transformations by reusing of previous type inferred expression instead of perform InferType multiple times

The test_pass_simplify_expr.py tests on my machine started to pass for 40 seconds vs 116 seconds main branch state

@elvin-n elvin-n changed the title Disable InferType if it was done and no changes after previous pass [Relay]Disable InferType if it was done and no changes after previous pass Jan 8, 2025
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

This optimizatin allows to speedup PatternRewriter transformations by
reusing of preious type inferred expression instead of perform
InferType multiple times
@elvin-n elvin-n force-pushed the amalyshe/dataflow_matcher_opt branch from e522684 to bd02406 Compare January 13, 2025 08:03
@echuraev
Copy link
Contributor

@tvm-bot rerun

1 similar comment
@yongwww
Copy link
Member

yongwww commented Jan 15, 2025

@tvm-bot rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants