Fix GPU detection in PerStoreFeatureNode #17593
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Description: Incorrect Assignment of
is_gpu
PropertySummary:
In the context of feature extraction using
meta_schedule
, theis_gpu
property was incorrectly assigned by directly comparing the target kind name to"cuda"
. This approach is not only too specific but also potentially unsafe, as it does not account for different GPU types or handle cases where the target might be undefined.Incorrect Code:
tvm/src/meta_schedule/feature_extractor/per_store_feature.cc
Line 1395 in 567eeed
Problems with the Incorrect Code:
"cuda"
and can vary based on library versions or configurations.Correct Implementation:
Explanation of Correct Code:
The corrected code checks if
"gpu"
exists within the list of keys associated with the target. This method is more robust because:"gpu"
in its keys, regardless of the underlying hardware or software platform.kind->name
.