From e055a0d2a08d7cce03f4028e30b3d28056ee645c Mon Sep 17 00:00:00 2001 From: Marcus Shawcroft Date: Fri, 7 Jun 2019 11:56:47 +0100 Subject: [PATCH 1/3] [CI] Clarify RAT exclude patterns. RAT exclude patterns are not matched across path separators. Patterns of the form xyz/* will match files and directories named xyz anywhere in the tree because the regexp /* contracts to "". Adjust the existing rat exclude patterns that appear to contain matches with path separators to be explicit about the pattern they actually match. --- tests/lint/rat-excludes | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/lint/rat-excludes b/tests/lint/rat-excludes index 934e65c2cad2..2f2a29b04b9f 100644 --- a/tests/lint/rat-excludes +++ b/tests/lint/rat-excludes @@ -1,6 +1,6 @@ # subdirectories -3rdparty/* -.github/* +3rdparty +.github # Binary or data files .*\.css @@ -28,7 +28,7 @@ # Generated modules .*\.egg-info -.*gen_modules/* +.*gen_modules .*doxygen core.cpp build From b36a11fb21ed293384248a22f4fbcf1078b02740 Mon Sep 17 00:00:00 2001 From: Marcus Shawcroft Date: Tue, 11 Jun 2019 10:25:59 +0100 Subject: [PATCH 2/3] [CI] RAT exclude patterns for jvm and tutorials The build process generates artificats into jvm/../targets and docs/../tutorials subdirectories, many of which trigger RAT. RAT exclude syntax does not match path separators so it is not possible to target specific built directories. This patch tells RAT to ignore and file or directory named 'jvm' and 'tutorials' irrespective of where they are located. This choice is conservative, and may result in source files being ingored from the RAT scan. --- tests/lint/rat-excludes | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/lint/rat-excludes b/tests/lint/rat-excludes index 2f2a29b04b9f..960e2658bb53 100644 --- a/tests/lint/rat-excludes +++ b/tests/lint/rat-excludes @@ -1,6 +1,8 @@ # subdirectories 3rdparty .github +jvm +tutorials # Binary or data files .*\.css From e6bd04045a5d149357c2122f26d75eac05c72742 Mon Sep 17 00:00:00 2001 From: Marcus Shawcroft Date: Tue, 11 Jun 2019 10:26:16 +0100 Subject: [PATCH 3/3] [CI] RAT exclude pattern for emacs lock files --- tests/lint/rat-excludes | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/lint/rat-excludes b/tests/lint/rat-excludes index 960e2658bb53..2e7a23a1ea4f 100644 --- a/tests/lint/rat-excludes +++ b/tests/lint/rat-excludes @@ -38,6 +38,7 @@ _static _build .*~ \#..*\# +\.#.* # Relay parser RelayLexer.py