Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gas sanitization median based #245

Closed
Siegrift opened this issue Apr 9, 2024 · 1 comment · Fixed by #258
Closed

Make gas sanitization median based #245

Siegrift opened this issue Apr 9, 2024 · 1 comment · Fixed by #258
Assignees

Comments

@Siegrift
Copy link
Collaborator

Siegrift commented Apr 9, 2024

On today's Airseeker call, we talked about:

  • Gas scaling using the latest gas price instead of sanitized one. When we sanitize and scale in short succession, we often end up overpaying.
  • Current (percentile based) sanitization can suffer if last few minutes cause a gas spike.
  • Sanitization could be based on the median of gas prices and multiplied by some factor and also cap the scaling.

The median could be parametrised, but in practice we will likely use only the median. There might be some edge cases, so this should be thought through a bit more. Even if the idea is sounds, it's best to see this work in practice.

@Siegrift
Copy link
Collaborator Author

Siegrift commented Apr 9, 2024

Specifics: https://api3workspace.slack.com/archives/C05TQPT7PNJ/p1712663616578319

Also update the spec.

@Siegrift Siegrift self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant