Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import deployed AirseekerRegistry (old DapiDataRegistry) addresses #82

Closed
Siegrift opened this issue Nov 9, 2023 · 3 comments
Closed

Comments

@Siegrift
Copy link
Collaborator

Siegrift commented Nov 9, 2023

Api3ServerV1 address is optional in Airseeker because and we fallback to the deployed address taken from api3-protocol-v1 repo. We should do the same for DapiDataRegistry once the contract is deployed.

@Siegrift Siegrift mentioned this issue Nov 9, 2023
@bbenligiray
Copy link
Member

As a note, arguably, the Api3ServerV1 deployment should live in the dapi-management repo as it's not a pure protocol contract

@Siegrift Siegrift added the blocked Blocked by something label Nov 19, 2023
@Siegrift Siegrift changed the title Import deployed DapiDataRegistry addresses Import deployed AirseekerRegistry (old DapiDataRegistry) addresses Dec 19, 2023
@bbenligiray bbenligiray removed the blocked Blocked by something label Feb 13, 2024
@bbenligiray
Copy link
Member

AirseekerRegistry is not a protocol contract / it's user specific so it shouldn't be auto-imported (and it's not exported in the first place for this reason)

@Siegrift
Copy link
Collaborator Author

Ok, in that case I think the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants