Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle timeouts and properly cleanup memory #91

Closed
Siegrift opened this issue Nov 13, 2023 · 1 comment · Fixed by #98
Closed

Handle timeouts and properly cleanup memory #91

Siegrift opened this issue Nov 13, 2023 · 1 comment · Fixed by #98
Assignees

Comments

@Siegrift
Copy link
Collaborator

Siegrift commented Nov 13, 2023

See discussion in #88 (comment)

Axios does not have any timeout by default. Ethers porovider has a 2 minute default timeout (but we can maybe set it explicitly). These are important to properly cleanup resources.

The go utils timeout can be applied as necessary. E.g. ensure that some loop calls do not overlap. This is tricky to do correctly because it's impossible to cancel running an already started function.

@Siegrift
Copy link
Collaborator Author

@Siegrift Siegrift changed the title Handle timeouts and properly cleanup memory. Handle timeouts and properly cleanup memory Nov 14, 2023
@vponline vponline self-assigned this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants