-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Beacons should have an encoded |
Template parameters were correct before the PR, there needs to be an encoded |
a0b0e45
to
c360606
Compare
Just to be clear, will any filed names change in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's all good now. I think this doesn't change data/documentation_metadata.json
so you shouldn't need to change anything for this PR specifically. However, we should address api3dao/services#17 in a separate PR and then you will probably need to read beaconName
from that JSON.
Yes, thanks for this and apologies for it taking me so long. I specifically tried to not make any changes to |
This PR removes the following fields from the deployed templates:
templateName
description
parameters
(which were encoded parameters)It also renames
decodedParameters
toparameters
.We retain
templateName
anddescription
in the beacon files.Also removes the erroneous 'mumbai' chain from
chains.json
, per issue #10