Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Remove extraneous template data #11

Merged
merged 6 commits into from
Feb 12, 2022
Merged

Conversation

aquarat
Copy link
Contributor

@aquarat aquarat commented Feb 11, 2022

This PR removes the following fields from the deployed templates:

  • templateName
  • description
  • parameters (which were encoded parameters)

It also renames decodedParameters to parameters.
We retain templateName and description in the beacon files.

Also removes the erroneous 'mumbai' chain from chains.json, per issue #10

@aquarat aquarat requested a review from bbenligiray February 11, 2022 08:53
@aquarat aquarat self-assigned this Feb 11, 2022
@aquarat aquarat linked an issue Feb 11, 2022 that may be closed by this pull request
@bbenligiray
Copy link
Member

Beacons should have an encoded parameters field as described here but they should be "0x" if we're not specifying any overriding parameters

@bbenligiray
Copy link
Member

Template parameters were correct before the PR, there needs to be an encoded parameters and a decoded decodedParameters field

@aquarat aquarat force-pushed the refactor-extraneous-parameters branch from a0b0e45 to c360606 Compare February 12, 2022 07:19
@wkande
Copy link
Member

wkande commented Feb 12, 2022

Just to be clear, will any filed names change in data/documentation_metadata.json. If they do I need to change the docs since it reads from this file in real time.

@bbenligiray bbenligiray self-requested a review February 12, 2022 11:33
Copy link
Member

@bbenligiray bbenligiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's all good now. I think this doesn't change data/documentation_metadata.json so you shouldn't need to change anything for this PR specifically. However, we should address api3dao/services#17 in a separate PR and then you will probably need to read beaconName from that JSON.

@aquarat
Copy link
Contributor Author

aquarat commented Feb 12, 2022

Thanks, it's all good now. I think this doesn't change data/documentation_metadata.json so you shouldn't need to change anything for this PR specifically. However, we should address api3dao/services#17 in a separate PR and then you will probably need to read beaconName from that JSON.

Yes, thanks for this and apologies for it taking me so long. I specifically tried to not make any changes to documentation_metadata.json so as to avoid consumers from being disrupted.

@aquarat aquarat merged commit 83a119d into main Feb 12, 2022
@aquarat aquarat deleted the refactor-extraneous-parameters branch February 12, 2022 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'mumbai' from chains
3 participants