Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load more doesn't work for commit history for specific key #3893

Closed
3 tasks done
nobodyiam opened this issue Aug 14, 2021 · 2 comments · Fixed by #3894
Closed
3 tasks done

Load more doesn't work for commit history for specific key #3893

nobodyiam opened this issue Aug 14, 2021 · 2 comments · Fixed by #3894

Comments

@nobodyiam
Copy link
Member

  • I have checked the discussions
  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Describe the bug
#3878 added support to filter commit history for specific key, but it seems the load more feature is not adjusted for this feature

To Reproduce
Steps to reproduce the behavior:

  1. change the same key 15 times, e.g a
  2. switch to change history
  3. filter the change histories with key a
  4. click Load more
  5. The latest histories were loaded instead of the previous ones

Expected behavior
More histories with key a should be displayed

Screenshots
image

After clicking Load more

image
@nobodyiam
Copy link
Member Author

@Accelerater would you please help to verify this bug?

@Accelerator96
Copy link
Contributor

ok

@Accelerator96 Accelerator96 mentioned this issue Aug 14, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix search history.
2 participants
@nobodyiam @Accelerator96