Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation messages are not escaped #2879

Closed
martinbonnin opened this issue Mar 15, 2023 · 1 comment · Fixed by #2951
Closed

Deprecation messages are not escaped #2879

martinbonnin opened this issue Mar 15, 2023 · 1 comment · Fixed by #2951
Assignees
@calvincestari
Labels
bug Generally incorrect behavior codegen Issues related to or arising from code generation planned-next Slated to be included in the next release
Milestone
Release 1.2

Comments

@martinbonnin
Copy link
Contributor

martinbonnin commented Mar 15, 2023 •
edited
Loading

Summary

The GraphQL following type:

type Venue {
   descriptionFr: String! @deprecated(reason: "use description(language: \"fr\") instead")
}

generates Swift code that doesn't compile:

        @available(*, deprecated, message: "description(language: "fr") instead")
        public var descriptionFr: String { __data["descriptionFr"] }

Many kudos to @djavan-bertrand for finding this ❤️
@martinbonnin martinbonnin added bug Generally incorrect behavior needs investigation labels Mar 15, 2023
@AnthonyMDev AnthonyMDev added this to the Release 1.1 milestone Mar 20, 2023
@AnthonyMDev AnthonyMDev self-assigned this Mar 20, 2023
@AnthonyMDev
Copy link
Contributor

Thank you for bringing this to our attention! Will get this resolved ASAP. Should be a quick fix.

@calvincestari calvincestari added planned-next Slated to be included in the next release codegen Issues related to or arising from code generation and removed needs investigation labels Mar 20, 2023
@AnthonyMDev AnthonyMDev modified the milestones: Release 1.1, Release 1.2 Apr 3, 2023
@calvincestari calvincestari mentioned this issue Apr 11, 2023
Merged
@thingdeux thingdeux mentioned this issue May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calvincestari calvincestari

Labels
bug Generally incorrect behavior codegen Issues related to or arising from code generation planned-next Slated to be included in the next release
Projects
None yet
Milestone
Release 1.2
Development

Successfully merging a pull request may close this issue.

fix: Escape deprecation messages apollographql/apollo-ios
3 participants
@calvincestari @martinbonnin @AnthonyMDev