makefile improvement - CLI

[asbhat]

Summary

After upgrading to Xcode v14.3 the InstallCLI Command Plugin seems to be missing.

I created a new project and installed apollo-ios but the plugin is still missing. Am I doing something wrong?

Version

v1.0.7

Steps to reproduce the behavior

1. Install Xcode v14.3
2. Create a new project
3. Add package apollo-ios
4. Right click on the project in the navigator
5. The command plugin is missing

Logs

No response

Anything else?

No response

[calvincestari]

Hi @asbhat - we've taken a look and don't have a clear idea on what could be causing it to be missing; our implementation of XcodeCommandPlugin hasn't changed. We're also concerned it could be a regression in Xcode 14.3 support for SPM plugins since the plugin is visible when opening a package.swift based project (vs. an Xcode project that uses SPM dependencies).

I realize it is inconvenient not having it in the menu and until we can figure out the root cause the workaround would be to grab the pre-built CLI binary we attach to each GitHub release and place that in the root of your project directory; the effect will be the same and the CLI has a version checker so if you ever update the dependency but forget to manually download the pre-built CLI it will warn you.

[asbhat]

Thanks for the response Calvin!

I did end up just grabbing the pre-built CLI binary (docs here) that works just fine.

I took a quick look at the plugin too and couldn't figure it out :(
but it does seem other projects are having similar issues (e.g., nicklockwood/SwiftFormat#1404), so you're probably right that it's a regression and something for Apple to fix.

Should I close the issue?

[calvincestari]

I think leave it open for a bit longer and let's monitor if it's showing up in many other libraries too.

[PawanSinghatia]

Hi @calvincestari , @asbhat please provide the exact steps for the pre-built CLI binary solution for this issue

[PawanSinghatia]

Thanks for the response Calvin!

I did end up just grabbing the pre-built CLI binary (docs here) that works just fine.

I took a quick look at the plugin too and couldn't figure it out :( but it does seem other projects are having similar issues (e.g., nicklockwood/SwiftFormat#1404), so you're probably right that it's a regression and something for Apple to fix.

Should I close the issue?

Ho w to grab the pre-built binary ?

[calvincestari]

It's attached to each GitHub release, in a file named apollo-ios-cli.tar.gz.

[BrentMifsud]

I'm experiencing this as well. Looks like its probably an Xcode bug.

[calvincestari]

I've confirmed this is happening in the Sourcery framework too. I haven't seen any sign of a new Xcode beta though, nor a quick release of 14.3.1 - I'm really not sure what's taking them so long to react to this.

[BrentMifsud]

It's happening with swiftgen as well.

Definitely a bug with Xcode

[e-001]

Perhaps this was just a change by Apple rather than a bug. The menu item is still available in our GQL package itself, just not the root context menu.

[dadouf]

Perhaps this was just a change by Apple rather than a bug. The menu item is still available in our GQL package itself, just not the root context menu.

This is an interesting workaround, and should work for most people who had generated the Apollo Swift code into a Swift package before the bug appeared. It just installs the apollo-ios-cli shortcut in the package's folder instead of the project's one, but then it can be moved. Works for me thanks!

[calvincestari]

It's an interesting workaround. I've only managed to get it to work when adding Apollo iOS as a local package though, if I add it a remote github-based package it's still missing from the menu.

Local package dependency vs. Remote package dependency.

[AnthonyMDev]

TODO:

• Add a comment to the documentation explaining the work around for using the makefile to build the CLI.
• Have the makefile command automatically move the built CLI to the project root directory.

[calvincestari]

I've confirmed that Xcode 14.3.1 RC resolves this issue. I'm going to change the title of this issue to reflect the work we still wanted to do.

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo iOS usage and allow us to serve you better.