Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port PR #674 to 1.0: improve validation error summary #691

Closed
SimonSapin opened this issue Oct 12, 2023 · 0 comments · Fixed by #776
Closed

Port PR #674 to 1.0: improve validation error summary #691

SimonSapin opened this issue Oct 12, 2023 · 0 comments · Fixed by #776
Assignees
@goto-bus-stop
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation

Comments

@SimonSapin
Copy link
Contributor

PR #674 was reverted in #690 (but kept in the compiler-v0.11 branch) in order to help compiler v1.0 to be merged into main.

Merging these improvements into 1.0 with git has proven difficult, so we’ll need to port them manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(compiler): port compiler validation errors to new diagnostics API apollographql/apollo-rs
2 participants
@SimonSapin @goto-bus-stop