From 7ffd5e238e0249f4942e405884edb49c69c2f9de Mon Sep 17 00:00:00 2001 From: Jesse Rosenberger Date: Fri, 26 Apr 2019 16:16:46 +0300 Subject: [PATCH] Remove now-unnecessary guard which checks for `errors`. This is no longer necessary after the changes in @jbaxleyiii's https://github.com/apollographql/apollo-server/pull/2574 (and @martijnwalraven's https://github.com/apollographql/apollo-server/pull/2416), which changed the error reporting to be captured via the newly introduced `didEncounterErrors`, rather than in `willResolveField` where it used to happen. Yay! --- packages/apollo-engine-reporting/src/extension.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/apollo-engine-reporting/src/extension.ts b/packages/apollo-engine-reporting/src/extension.ts index bc26dfdb0b8..4dd207d6a38 100644 --- a/packages/apollo-engine-reporting/src/extension.ts +++ b/packages/apollo-engine-reporting/src/extension.ts @@ -288,11 +288,6 @@ export class EngineReportingExtension } public didEncounterErrors(errors: GraphQLError[]) { - // This life-cycle method is only invoked to capture errors. - if (!errors) { - return; - } - errors.forEach(err => { // In terms of reporting, errors can be re-written by the user by // utilizing the `rewriteError` parameter. This allows changing