Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apollo-server-plugin-base depends on apollo-server-core but doesn't include it as a dependency #2964

Closed
mohsen1 opened this issue Jul 1, 2019 · 3 comments

Comments

@mohsen1
Copy link

mohsen1 commented Jul 1, 2019

As it was discovered here:

yarnpkg/berry#271 (comment)

I see in package.json apollo-server-core is a dev dependency. is this a bug or was it intended?

@JacksonKearl
Copy link

Left a comment on the attached issue. In short: it's a dev dependency because it only uses the typings, but I'm not sure what the appropriate way to express that is.

@abernix
Copy link
Member

abernix commented Jul 2, 2019

The primary reason we don't want to make apollo-server-plugin-base have a regular (vs. dev) dependency on the apollo-server-core package is to maintain separation between the apollo-server-plugin-base package and specific versions of apollo-server-core (and other integrations), in order to allow plugins to evolve at their own rate while still being compatible at least the major version of Apollo Server.

This may be, yet another, use-case for an apollo-server-types package!

@abernix
Copy link
Member

abernix commented Jul 2, 2019

I've opened #2970 to track the actual chore necessary to make that happen, but closing this bug is dependent on that getting resolved!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants