Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial data return prematurely fails (watchQuery) #193

Closed
gauravtiwari opened this issue May 10, 2016 · 4 comments
Closed

Partial data return prematurely fails (watchQuery) #193

gauravtiwari opened this issue May 10, 2016 · 4 comments
Labels
🐞 bug 🚨 high-priority

Comments

@gauravtiwari
Copy link

gauravtiwari commented May 10, 2016 •
edited
Loading

Hey folks,

Getting following error, when using returnPartialData with watchQuery (looks like it's trying to get the data from Store, before it's available)

store.js:11Caught an exception! Error: Can't find field posts on object [object Object].(…)
This was referenced May 10, 2016
Closed
Closed
@stubailo
Copy link
Contributor

This is a pretty bad bug! Thanks for the report, we should get it fixed ASAP.

@stubailo
Copy link
Contributor

Oops, looks like we have exactly 0 unit tests for returnPartialData. That explains why that broke...

stubailo pushed a commit that referenced this issue May 11, 2016
Make failing test for #193
d0910b0
@stubailo stubailo mentioned this issue May 11, 2016
Merged
4 tasks
stubailo pushed a commit that referenced this issue May 11, 2016
Make failing test for #193
4e66277
stubailo pushed a commit that referenced this issue May 11, 2016
0.3.5
c220a12 
- Improve error message when a dev forgets `gql` to link to docs. [PR #181](#181)
- Memoize results from `gql`, so that we save time on parsing, and we can use `===` to compare queries for performance. [Issue #199](#199) [PR #200](#200)
- Fix error when using `returnPartialData`. [Issue #193](#193) [PR #201](#201)
@stubailo
Copy link
Contributor

This should be fixed in Apollo Client 0.3.5. Please let me know if it isn't!

@gauravtiwari
Copy link
Author

@stubailo Thanks Sashko. Yeah, me too looked at unit tests and immediately realised that something is wrong with implementation. Great work 👍

jbaxleyiii pushed a commit that referenced this issue Oct 17, 2017
@META-DREAMER @helfer
fix image paths and README instructions (#193)
ae3e19a
jbaxleyiii pushed a commit that referenced this issue Oct 18, 2017
@helfer
Merge pull request #193 from apollographql/helfer-patch-4
bc5e9b0 
Create migration.md
@snyk-bot snyk-bot mentioned this issue Oct 8, 2021
Open
This was referenced Feb 21, 2022
Open
Open
Open
This was referenced Apr 21, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 29, 2022
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Apr 30, 2022
Open
This was referenced May 14, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced May 21, 2022
Open
Open
Open
Open
Open
Open
This was referenced May 25, 2022
Open
Open
Open
This was referenced May 29, 2022
Open
Open
Open
This was referenced May 30, 2022
Open
Open
Open
Open
Open
Open
This was referenced Jun 11, 2022
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Jun 14, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug 🚨 high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stubailo @gauravtiwari