Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize gql #199

Closed
stubailo opened this issue May 11, 2016 · 0 comments
Closed

Memoize gql #199

stubailo opened this issue May 11, 2016 · 0 comments
Assignees
@stubailo
Labels
🐞 bug

Comments

@stubailo
Copy link
Contributor

Since gql now creates a new object every time it parses, that breaks react-apollo change detection. We should make the same queries === each other, like the original strings do.
@stubailo stubailo self-assigned this May 11, 2016
@stubailo stubailo mentioned this issue May 11, 2016
Closed
stubailo pushed a commit that referenced this issue May 11, 2016
Memoize gql parse results
d299820 
Fixes #199
@stubailo stubailo mentioned this issue May 11, 2016
Merged
4 tasks
stubailo pushed a commit that referenced this issue May 11, 2016
0.3.5
c220a12 
- Improve error message when a dev forgets `gql` to link to docs. [PR #181](#181)
- Memoize results from `gql`, so that we save time on parsing, and we can use `===` to compare queries for performance. [Issue #199](#199) [PR #200](#200)
- Fix error when using `returnPartialData`. [Issue #193](#193) [PR #201](#201)
jbaxleyiii pushed a commit that referenced this issue Oct 17, 2017
@nicolaslopezj
Fix network interface link (#199)
a4fbb81
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stubailo stubailo

Labels
🐞 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stubailo