-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't fire the observer if the result of a query hasn't changed #400
Comments
I'm unsure if I'm running into the same thing, or a variation on it: I have a |
@nevir Hm. That should not happen if the part of the store associated with the store was left untouched. Could you file an issue that would allow us to reproduce the problem? (a unit test would also be great!) |
Since #402 was merged, this issue can now be closed. |
And deployed! |
@nevir can you check if |
@stubailo can confirm - all better as of |
Sweet! It really helped in our app as well. |
If we have a
watchQuery
observer and we receive a result from the server that is identical to the last result we handed to the observer, we should not call the observer at all. This will prevent solutions like usingshouldComponentUpdate
and will reduce useless re-renders on the page.The text was updated successfully, but these errors were encountered: