Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named fragments #80

Closed
stubailo opened this issue Apr 7, 2016 · 3 comments
Closed

Support named fragments #80

stubailo opened this issue Apr 7, 2016 · 3 comments
Assignees

Comments

@stubailo
Copy link
Contributor

stubailo commented Apr 7, 2016

Some questions:

  1. Do we inline the fragments, or try to keep the original names?
  2. What do we do about variables?
  3. Do the fragments return their own data, or does the UI component get it passed in from the parent?

More to think about later. The main question is, how critical is named fragment support for the alpha launch? It's one of the flagship features of the Relay API.

@stubailo
Copy link
Contributor Author

This issue is about using fragments for improved query readability. For including fragments from other places, refer to #148. This feature could be implemented first.

@stubailo stubailo self-assigned this May 5, 2016
@stubailo stubailo added this to the 5/10 cycle milestone May 5, 2016
@stubailo
Copy link
Contributor Author

stubailo commented May 6, 2016

After talking to @helfer, my strategy is going to be to inline all of the fragments before doing anything else, and fall onto the inline fragment feature.

@helfer
Copy link
Contributor

helfer commented Jun 2, 2016

#251 will solve this completely, afaict.

@zol zol added the fixed label Jun 2, 2016
@helfer helfer closed this as completed Jun 4, 2016
@helfer helfer removed the fixed label Jun 4, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants