Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types against GraphQL 0.8.2 and @types/graphql #934

Closed
wants to merge 1 commit into from

Conversation

intellix
Copy link
Contributor

@intellix intellix commented Nov 18, 2016

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

closes #927
depends on: DefinitelyTyped/DefinitelyTyped#12767

Currently getting a few errors with GraphQLError type as the @types/graphql is saying some fields are required. Some changes are needed before that gets merged and then this can be.

Just wanted to push some work before bed and someone else spends the same time on this :)

@intellix
Copy link
Contributor Author

intellix commented Nov 20, 2016

Also depends on this: DefinitelyTyped/DefinitelyTyped#12800 to fix GraphQLError usage in tests

@intellix intellix force-pushed the types-graphql-0.8.2 branch from a1e60a8 to a05f116 Compare November 20, 2016 14:55
@intellix
Copy link
Contributor Author

That fixes all of the errors throughout compilation. I'm still getting errors about Namespace _ not having some exported members but that'll not be to do with anything I did.
When DefinitelyTyped#12800 is merged, this is good to go

@intellix
Copy link
Contributor Author

@intellix intellix changed the title [WIP] Update types against GraphQL 0.8.2 and @types/graphql Update types against GraphQL 0.8.2 and @types/graphql Nov 21, 2016
@intellix intellix force-pushed the types-graphql-0.8.2 branch from a05f116 to c558cf4 Compare November 23, 2016 09:47
@intellix
Copy link
Contributor Author

intellix commented Dec 6, 2016

all depended branches were merged. This should be ready to go

@helfer
Copy link
Contributor

helfer commented Dec 13, 2016

@intellix Awesome! Do you have time to rebase/merge the branch? As soon as that's done, we should be ready to drop typed-graphql.

@intellix intellix force-pushed the types-graphql-0.8.2 branch from af153b5 to 3dc1f3d Compare December 13, 2016 19:00
@intellix
Copy link
Contributor Author

Your wish is my command! have fun re-reviewing :P

@stubailo
Copy link
Contributor

Closing in favor of #1041

@stubailo stubailo closed this Dec 14, 2016
helfer added a commit that referenced this pull request Jan 5, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change typed-graphql to @types/graphql
3 participants