Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batcherPollInterval as an option to ApolloClient #395

Merged
merged 6 commits into from
Jul 13, 2016
Merged

Add batcherPollInterval as an option to ApolloClient #395

merged 6 commits into from
Jul 13, 2016

Conversation

Poincare
Copy link
Contributor

@Poincare Poincare commented Jul 12, 2016 •
edited
Loading

Adds an option that lets the application developer specify the width of the batcher's polling interval. Fixes #394

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@stubailo
Copy link
Contributor

I'm curious - what spurred the need for this change? Was this a result of Galaxy investigation?

@Poincare
Copy link
Contributor Author

Yup, the galaxy ui. It became pretty evident that tweaking the batcher polling interval on a per-app basis would be useful.

@stubailo
Copy link
Contributor

What interval made sense for galaxy?

@Poincare
Copy link
Contributor Author

10 ms seems to work okay for Galaxy but as I play around with it more, I'll have a better idea.

@stubailo
Copy link
Contributor

Let's rename this to batchInterval.

@Poincare
Copy link
Contributor Author

Good call, fixed @stubailo

@stubailo stubailo merged commit 963af2a into master Jul 13, 2016
@zol zol removed the in progress label Jul 13, 2016
@stubailo stubailo deleted the set_polling_interval branch September 20, 2016 03:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Poincare @stubailo @zol