Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add fields to the root mutation/query #463

Merged
merged 2 commits into from
Jul 26, 2016
Merged

Conversation

amandajliu
Copy link
Contributor

@amandajliu amandajliu commented Jul 25, 2016

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@stubailo stubailo force-pushed the addTypename-transform branch from 5bdf5d0 to aa71518 Compare July 26, 2016 04:40
@stubailo stubailo merged commit c96a8cf into master Jul 26, 2016
@rricard
Copy link
Contributor

rricard commented Jul 26, 2016

@stubailo: this PR introduces a change that breaks the apolloFetchMore directive stripping. The way it has been done suppresses all query transformers on root query.

@rricard
Copy link
Contributor

rricard commented Jul 26, 2016

See #374

@rricard rricard mentioned this pull request Jul 26, 2016
4 tasks
@stubailo stubailo deleted the addTypename-transform branch September 20, 2016 03:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants