Remove unused variables from queries #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After diffing queries, removing parts that could be queried from the store, some variables in the query can become unused, causing errors pointing out unused variables. This patch, walks the query and fragments asts and filters out the variables no longer used.
|
Fixes #496 |
| return uniq(variables); | ||
| } | ||
|
|
||
| export function removeUnusedVariablesFromDiffedQuery ( |
There was a problem hiding this comment.
Remove "diffed" from this name - since it doesn't really have anything to do with diffed queries.
| if (field.arguments) { | ||
| variables = flatten(field.arguments.map((arg) => { | ||
| if (arg.value.kind === 'Variable') { | ||
| return [(arg.value as any).name.value]; |
There was a problem hiding this comment.
Use Variable instead of any
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
After diffing queries, removing parts that could be queried from the store,
some variables in the query can become unused, causing errors pointing
out unused variables.
This patch, walks the query and fragments asts and filters out the variables
no longer used.