[Bug?] ObservableQuery#refetch no longer rejects on error #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behavior: `refetch()` returns `data: undefined` and does not reject if the underlying request fails, or has errors. It would be ideal if it were to reject, IMO. For example, using `refetch` via `react-apollo` on a pull to refresh, and knowing when to display something to the user indicating error.
|
👍 thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is just a failing test; not a fix)
Current behavior:
refetch()returnsdata: undefinedand does not reject if the underlying request fails, or has errors.It used to reject (sometime in 0.4.x, but unsure when this changed), and that behavior was definitely helpful for responding to errors (and displaying UI when the user makes an explicit request for data)