Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deepAssign, use lodash.merge to fix null fragment bug #683

Merged
merged 2 commits into from
Sep 20, 2016

Conversation

helfer
Copy link
Contributor

@helfer helfer commented Sep 20, 2016

Fixes #678

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)

@helfer
Copy link
Contributor Author

helfer commented Sep 20, 2016

lodash.merge seems to be quite large, it brings the size to 40.8Kb, which causes tests to fail. We could bump the size for now to merge the fix, and then look for a smaller library.

@stubailo
Copy link
Contributor

Sgtm

@helfer helfer merged commit 086dc97 into master Sep 20, 2016
@jbaxleyiii jbaxleyiii deleted the fix-deep-assign branch July 20, 2017 17:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants