Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root key #688

Merged
merged 3 commits into from
Sep 21, 2016
Merged

Fix root key #688

merged 3 commits into from
Sep 21, 2016

Conversation

helfer
Copy link
Contributor

@helfer helfer commented Sep 21, 2016

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)

@helfer
Copy link
Contributor Author

helfer commented Sep 21, 2016

PR-ception successful 🎉

@helfer helfer merged commit da81f28 into master Sep 21, 2016
@jbaxleyiii jbaxleyiii deleted the fix-rootKey branch July 20, 2017 17:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@helfer