Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdebug fallsbacks too often #162

Open
apolopena opened this issue Dec 17, 2021 · 3 comments
Open

xdebug fallsbacks too often #162

apolopena opened this issue Dec 17, 2021 · 3 comments
Assignees
Labels
optimization refactor or enhance code to enhance performance
Milestone

Comments

@apolopena
Copy link
Owner

apolopena commented Dec 17, 2021

Describe the bug

The xdebug log show this when it first starts up and debug_on or debug_off is called:

[5382] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[5382] [Config] INFO: Trigger value for 'XDEBUG_SESSION' not found, so not activating
[5382] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[5382] [Config] INFO: Trigger value for 'XDEBUG_SESSION' not found, so not activating
[5382] [Config] INFO: Trigger value for 'XDEBUG_TRIGGER' not found, falling back to 'XDEBUG_SESSION'
[5382] [Config] INFO: Trigger value for 'XDEBUG_SESSION' not found, so not activating

Screenshots

Steps to reproduce

Expected behavior

Additional information

@apolopena apolopena added the bug Something isn't working label Dec 17, 2021
@apolopena apolopena self-assigned this Dec 17, 2021
@apolopena apolopena added not a bug Looks like a bug but is not a bug and removed bug Something isn't working labels Dec 18, 2021
@apolopena
Copy link
Owner Author

This is expected behavior. xdebug falls back to XDEBUG_SESSION when using XDEBUG_SESSION_START in a GET request which is the mechanism we use to toggle xdebug sessions on and off. The alternative would be to use XDEBUG_SESSION in a get request instead of XDEBUG_SESSION_START but is unecessary due to the fallback mechanism that xdebug uses.

@apolopena
Copy link
Owner Author

Reopening since the xdebug fallback mechanism makes multiple calls and fallback on every trigger of a debug session and everytime something is debugged. This is an optimization.

@apolopena apolopena reopened this Dec 18, 2021
@apolopena apolopena added optimization refactor or enhance code to enhance performance and removed not a bug Looks like a bug but is not a bug labels Dec 18, 2021
@apolopena
Copy link
Owner Author

This optimization requires a full refactoring of the debug_on and debug_off browser funtions as well as all xdebug configs.

@apolopena apolopena changed the title xdebug sessions are on all the time, debug_on and debug_off no longer work xdebug fallsbacks too often Dec 21, 2021
@apolopena apolopena added this to the Backlog milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization refactor or enhance code to enhance performance
Projects
None yet
Development

No branches or pull requests

1 participant