From cd2fec7c5ce7f1649995b6e262a8b8b510c222b0 Mon Sep 17 00:00:00 2001 From: apolopena <3060702+apolopena@users.noreply.github.com> Date: Mon, 10 May 2021 13:42:45 -0700 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=90=9B=20FIX:=20https://github.com/ap?= =?UTF-8?q?olopena/gitpod-laravel-starter/issues/131?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .gp/conf/nginx/nginx.conf | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gp/conf/nginx/nginx.conf b/.gp/conf/nginx/nginx.conf index aa2080e9..234f186d 100644 --- a/.gp/conf/nginx/nginx.conf +++ b/.gp/conf/nginx/nginx.conf @@ -46,8 +46,10 @@ http { index index.html index.htm index.php; # Bugfix: https://github.com/apolopena/gitpod-laravel-starter/issues/96 # Rewrite urls that dont have a trailing slash to have a trailing slash thus bypassing redirection. + # Bugfix: https://github.com/apolopena/gitpod-laravel-starter/issues/131 + # force rewrite to use https in order to bypass mixed content errors when in an iframe if (-d $request_filename) { - rewrite [^/]$ $scheme://$http_host$uri/ permanent; + rewrite [^/]$ https://$http_host$uri/ permanent; } try_files $uri $uri/ /index.php$is_args$args; } From 9bc2cc0d53aba115fe2be546434b853bb8ade2d7 Mon Sep 17 00:00:00 2001 From: apolopena <3060702+apolopena@users.noreply.github.com> Date: Mon, 10 May 2021 13:44:42 -0700 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=90=9B=20FIX:=20https://github.com/ap?= =?UTF-8?q?olopena/gitpod-laravel-starter/issues/130=20opening=20url=20pat?= =?UTF-8?q?hs=20that=20end=20in=20a=20file=20name=20gives=20a=20404?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .gp/bash/open-preview.sh | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.gp/bash/open-preview.sh b/.gp/bash/open-preview.sh index ddf54ea9..7368af3c 100644 --- a/.gp/bash/open-preview.sh +++ b/.gp/bash/open-preview.sh @@ -15,14 +15,8 @@ exit 1 . .gp/bash/spinner.sh -__path= -if [[ -n $1 ]]; then - if [[ ! $1 =~ \/$ ]]; then - __path=/$1/ - else - __path=/$1 - fi -fi +__path=/$1 + __port=$(bash .gp/bash/helpers.sh get_default_server_port) if [[ $(bash .gp/bash/helpers.sh is_inited) == 0 ]]; then . .gp/bash/spinner.sh &&