Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strike Data Grid should control 'Load More' button visibility on data change #163

Closed
kevinberonilla opened this issue Nov 30, 2017 · 1 comment
Assignees

Comments

@kevinberonilla
Copy link
Contributor

A change handler can be added to the data attribute that runs logic to set the proper v.showLoadMore value. This is currently only an issue if a table initially has more than 10 rows (or whatever v.loadMoreAmount is set to), and then changes to have less rows than that. The 'Load More' button still appears in that situation.

Also, there's no space in the button text; should be 'Load More' not 'LoadMore.'
screen shot 2017-11-30 at 10 55 25 am

@daneowens3
Copy link
Contributor

I've added a fix so the button is handled more intuitively and added a space to the button's label. Will reflect in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants