fix: relax webview match #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, Fixed by using newer typescript |
|
ok, the CI failure has been fixed by using newer typescript |
mykola-mokhnach
approved these changes
Aug 14, 2023
|
just FYI @KazuCocoa: there is a pending PR (ece12ee, tag 5.14.0-alpha2) about fully transforming this driver into TS module. It has been touched at 3rd of July 2023 for the last time. Each change that we add to master would require this PR to be rebased and take more time. Although, I am not quite sure about the current progress on it. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
## [5.14.2](v5.14.1...v5.14.2) (2023-08-14) ### Bug Fixes * relax webview matching logic of devtools_remote ([#836](#836)) ([7c52b81](7c52b81))
|
🎉 This PR is included in version 5.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appium/appium#17528
Most diff is by
prettier... so let me list what I did here:DEVTOOLS_SOCKET_PATTERNto accept Unable to match webview when automating test dingtalk h5. appium#17528 naming logic as wellconst matchedSocketName = socketNameMatch[2];to reduce code duplicationsdescribe('DEVTOOLS_SOCKET_PATTERN', function () {, to check the patternLocal run: