refactor: Isolate base Android functionality #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests obviously fail for now and need an update. Only the codebase has been updated to a buildable state. |
|
Took a look entirely. I don't have any objections to this |
jlipps
approved these changes
Jan 19, 2024
…droid-driver into refactor_mixins # Conflicts: # lib/helpers/webview.ts # test/unit/commands/webview-helper-specs.js
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
## [8.0.0](v7.8.3...v8.0.0) (2024-01-24) ### ⚠ BREAKING CHANGES * Removed androidHelpers export. Corresponding methods are now integrated into the driver * Removed webviewHelpers export. Corresponding methods are now integrated into the driver * Removed redundant exports related to io.appium.settings. * Removed deprecated APIs related to launchApp/closeApp/reset * Removed the unused unlocker property from the driver. The mixin typesystem has been aligned. There are no explicit mixin definitions, which basically duplicate each method signature. Instead all types are now provided next to method definitions. Improved grouping of different commands. Made it more explicit which of them are designed for export and which are just internal helpers Improved helper methods design, so they don't need to retrieve driver-specific properties (like log or adb) via command line args, but use this context and explicit binding instead. Marked legacy JWP touch-related methods as deprecated. They must be eventually replaced with proper W3C implementations. Removed unused declarations for non-implemented methods. ### Code Refactoring * Isolate base Android functionality ([#901](#901)) ([70e6233](70e6233))
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removed androidHelpers export. Corresponding methods are now integrated into the driver
BREAKING CHANGE: Removed webviewHelpers export. Corresponding methods are now integrated into the driver
BREAKING CHANGE: Removed redundant exports related to io.appium.settings.
BREAKING CHANGE: Removed deprecated APIs related to launchApp/closeApp/reset
BREAKING CHANGE: Removed the unused
unlockerproperty from the driver.The mixin typesystem has been aligned. There are no explicit mixin definitions, which basically duplicate each method signature. Instead all types are now provided next to method definitions.
Improved grouping of different commands. Made it more explicit which of them are designed for export and which are just internal helpers
Improved helper methods design, so they don't need to retrieve driver-specific properties (like
logoradb) via command line args, but usethiscontext and explicit binding instead.Marked legacy JWP touch-related methods as deprecated. They must be eventually replaced with proper W3C implementations.
Removed unused declarations for non-implemented methods.