From b056407adbb9c0316e04f4e5a8784344058ef3b2 Mon Sep 17 00:00:00 2001 From: Valery Yatsynovich Date: Tue, 30 Jan 2024 12:30:58 +0200 Subject: [PATCH] fix: Set correct geolocation coordinates of the current device --- .../java/io/appium/java_client/remote/SupportsLocation.java | 2 +- .../java/io/appium/java_client/android/AndroidDriverTest.java | 4 ++-- src/test/java/io/appium/java_client/ios/IOSDriverTest.java | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/io/appium/java_client/remote/SupportsLocation.java b/src/main/java/io/appium/java_client/remote/SupportsLocation.java index 504f418b6..45d81f36c 100644 --- a/src/main/java/io/appium/java_client/remote/SupportsLocation.java +++ b/src/main/java/io/appium/java_client/remote/SupportsLocation.java @@ -90,6 +90,6 @@ default void setLocation(io.appium.java_client.Location location) { locationParameters.put("latitude", location.getLatitude()); locationParameters.put("longitude", location.getLongitude()); Optional.ofNullable(location.getAltitude()).ifPresent(altitude -> locationParameters.put("altitude", altitude)); - execute(MobileCommand.SET_LOCATION, Map.of("location", locationParameters)); + execute(MobileCommand.SET_LOCATION, Map.of("location", locationParameters.build())); } } diff --git a/src/test/java/io/appium/java_client/android/AndroidDriverTest.java b/src/test/java/io/appium/java_client/android/AndroidDriverTest.java index e1ff99d2e..76753d75d 100644 --- a/src/test/java/io/appium/java_client/android/AndroidDriverTest.java +++ b/src/test/java/io/appium/java_client/android/AndroidDriverTest.java @@ -16,12 +16,12 @@ package io.appium.java_client.android; +import io.appium.java_client.Location; import io.appium.java_client.appmanagement.ApplicationState; import org.apache.commons.io.FileUtils; import org.hamcrest.Matchers; import org.junit.jupiter.api.Test; import org.openqa.selenium.ScreenOrientation; -import org.openqa.selenium.html5.Location; import java.io.File; import java.time.Duration; @@ -192,7 +192,7 @@ public void toggleLocationServicesTest() { @Test public void geolocationTest() { - Location location = new Location(45, 45, 100); + Location location = new Location(45, 45, 100.0); driver.setLocation(location); } diff --git a/src/test/java/io/appium/java_client/ios/IOSDriverTest.java b/src/test/java/io/appium/java_client/ios/IOSDriverTest.java index b5d718eb8..438178e36 100644 --- a/src/test/java/io/appium/java_client/ios/IOSDriverTest.java +++ b/src/test/java/io/appium/java_client/ios/IOSDriverTest.java @@ -16,6 +16,7 @@ package io.appium.java_client.ios; +import io.appium.java_client.Location; import io.appium.java_client.appmanagement.ApplicationState; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Disabled; @@ -23,7 +24,6 @@ import org.openqa.selenium.By; import org.openqa.selenium.ScreenOrientation; import org.openqa.selenium.WebElement; -import org.openqa.selenium.html5.Location; import org.openqa.selenium.remote.RemoteWebElement; import org.openqa.selenium.remote.Response; import org.openqa.selenium.remote.http.HttpMethod; @@ -88,7 +88,7 @@ public void getDeviceTimeTest() { @Disabled @Test public void geolocationTest() { - Location location = new Location(45, 45, 100); + Location location = new Location(45, 45, 100.0); try { driver.setLocation(location); } catch (Exception e) {