Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Poll Delay in Appium Fluent Wait #2111

Closed
AlessandroMiccoli opened this issue Feb 3, 2024 · 2 comments · Fixed by #2116
Closed

Incorporate Poll Delay in Appium Fluent Wait #2111

AlessandroMiccoli opened this issue Feb 3, 2024 · 2 comments · Fixed by #2116

Comments

@AlessandroMiccoli
Copy link
Contributor

Description

I need a poll delay before starting to look for an element. At the moment, I didn't find this feature inAppiumFluentWait.

Environment

  • Java client build version: 8.5.1

Current Solution

When I need a poll delay, I use the library awaitility, which provides this feature and others. Or I find an alternative solution using TimeUnit#sleep.

Code

I would like to have something like this:

AppiumFluentWait<>(this.driver).pollDelay(pollDelay). etc...

Questions:

  1. Is there a reason for this missing feature?
  2. What is the right way to do it, even with the last version of the appium java-client library?
  3. If there isn't a solution with the library, is it something you are interested in having it? Probably, I could find some time to integrate it.
@valfirst
Copy link
Collaborator

valfirst commented Feb 5, 2024

@AlessandroMiccoli please feel free to create PR

@AlessandroMiccoli
Copy link
Contributor Author

@valfirst I created the PR 2116

I see a lot of new features we could implement (i.e. setDefaultValues), but probably the best place is directly in Selenium method FluentWait. What do you think?

I just implemented the pollDelay, so I was not out of scope.

@valfirst valfirst linked a pull request Feb 15, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants